I preface my post by saying that I see your post as a fine ideal of what a warrior should be, and in no way to I mean to belittle it, so if I come across that way, I apologize in advance.

One of the reasons that flowery warrior codes were invented was to motivate warriors to behave during peace time and to keep them in line during war. Historically, warriors would happilly fight their wars with each other within a region, with the populace suffering the results thereof. Wealth and personal gain has always been a strong motivating factor for warriors. The idea of joining the military for pay and benefits is neither good nor bad in and of itself, and the idea certainly is right in line with what classically motivates warriors.
Daniel
Being a member of law enforcement makes you a peace keeper, not a warrior. The potential for exchange of gunfire does not change this. Unless you are a part of a society wherein law enforcement and the military are one in the same (or a part of occupational forces that assume the duties of law enforcement), law enforcement is generally not the duty of warriors or their modern analogues.To be a true warrior you have to be a member (past or present) of the military or law enforcement; sorry firefighters, you are brave but you don't have the duty of charging into a gun fight as brave as you are for what you do.
All worthy things. While they are not technical qualifications for being an actual warrior, they certainly would make one a much better warrior. Certainly, the above represents a noble ideal.In addition to this you have to have impeccable moral character, an understanding of duty/honor, high integrity, the ability to make hard (just) decisions and the desire to be the best you can be in all aspects of life .

One of the strongest motivations historically for war has been one group's desire to possess that which another group has, be it land, resources, wealth, or stature. Historically, warriors' motivations were seldom so pure.(not one of those who are wearing a uniform for the pay & benefits).
One of the reasons that flowery warrior codes were invented was to motivate warriors to behave during peace time and to keep them in line during war. Historically, warriors would happilly fight their wars with each other within a region, with the populace suffering the results thereof. Wealth and personal gain has always been a strong motivating factor for warriors. The idea of joining the military for pay and benefits is neither good nor bad in and of itself, and the idea certainly is right in line with what classically motivates warriors.
Daniel